Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of jetty.http.port property for jetty maven plugin #12183

Conversation

janbartel
Copy link
Contributor

The order of the jetty.http.port property for forked jetty execution with the jetty maven plugin needs to be changed - it now must be before any of the xml files that might reference it. Fixed for ee8/9/10.

@janbartel janbartel requested a review from olamy August 21, 2024 08:11
@janbartel janbartel self-assigned this Aug 21, 2024
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
as this issue was found by accident/chance maybe we could some test to check the content of the file jetty.port.file and ensure it's not 8080?

@janbartel janbartel merged commit 36ec04f into jetty-12.0.x Aug 22, 2024
11 checks passed
@janbartel janbartel deleted the jetty-12.0.x-fix-jetty.http.port-for-jetty-maven-plugin branch August 22, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants